Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only sync ui #125

Merged
merged 5 commits into from Nov 20, 2018
Merged

Only sync ui #125

merged 5 commits into from Nov 20, 2018

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Nov 14, 2018 •
edited

Fix for bsc#1039985, in previous attempt bsc#893065 it was fixed in SLE but broken in openSUSE.

OpenSUSE

opensuseinstallation

SLES

slesinst

Textmode

slesinsttext

In a running system

screenshot from 2018-11-20 09-21-20
screenshot from 2018-11-20 09-21-17
running
installationstylerunning

@coveralls
Copy link

coveralls commented Nov 14, 2018 •
edited

Coverage Status

Coverage decreased (-0.04%) to 54.794% when pulling 35d0c6f on only_sync_ui into 653de08 on SLE-15-GA.

@teclator teclator changed the base branch from only_sync to SLE-15-GA November 19, 2018 08:47
@lslezak
Copy link
Member

lslezak commented Nov 20, 2018

Unfortunately in the 80x25 mode the Manually radio button at the top is not displayed. 😟

But there is still enough vertical space between the elements or above the [Accept] [Cancel] buttons.

You can use the VSpacing(UI::TextMode() ? 0 : 1) tricks mentioned earlier.

@teclator teclator closed this Nov 20, 2018
@teclator teclator reopened this Nov 20, 2018
@teclator teclator mentioned this pull request Nov 20, 2018
Merged
lslezak
lslezak approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit 2b86675 into SLE-15-GA Nov 20, 2018
@teclator teclator deleted the only_sync_ui branch November 20, 2018 11:19
@teclator teclator mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teclator @coveralls @lslezak