Fixed some tests (bsc#983486). #66
Conversation
Josef Reidinger fixed the ntp lense in this commit: hercules-team/augeas@01e4c42 Basically before the fix it doesn't expect to have restrict records with IPv4 explicitly, as for example: restrict -4 default So before the fix "-4" was treated as an "address" and "default" as an option what is wrong. With the new lense CFA will read the ip version correctly.
| @@ -359,13 +359,13 @@ def ntp_conf(file) | |||
|
|
|||
| describe "#options" do | |||
| it "obtains the options of the record" do | |||
| expect(record.options).to eq(%w(default notrap nomodify nopeer)) | |||
There was a problem hiding this comment.
default is not an option but an address
| @@ -679,7 +683,7 @@ | |||
| end | |||
|
|
|||
| it "initializes restrict records" do | |||
| expect(subject.restrict_map.size).to eql(4) | |||
| expect(subject.restrict_map.size).to eql(3) | |||
There was a problem hiding this comment.
Basically it only reads 3 restrict records because they are indexed by the "address" and
restrict -4 default
restrict -6 default
are indexed by the "default" key. With the older lense there was an error which added "-4" as an address that is the reason of having 4 entries previously.
teclator
changed the title
teclator
changed the title
| @@ -65,9 +65,9 @@ rake install DESTDIR="%{buildroot}" | |||
| %files | |||
| %defattr(-,root,root) | |||
| %dir %{yast_yncludedir}/ntp-client | |||
| %{yast_dir}/clients/* | |||
There was a problem hiding this comment.
it can be %{yast_clientdir}/*
|
LGTM. regarding failing travis only option I see is to install somehow new lense ( from some ubuntu repo or manually ) or wait when @lslezak POC with docker will be used more widely. |
teclator
changed the title
|
It's green now! The Docker rocks! 👍 |
|
Cool!!, thnx @lslezak for make our lives better!! well at least more green ;) and thnx @jreidinger for review!! |
Just fixed some tests that does not allow to build the package correctly. Travis does not complain because it uses the old ntp.lense
Josef Reidinger fixed the ntp lense in this commit:
hercules-team/augeas@01e4c42
Basically before the fix it doesn't expect to have restrict records with IPv4 explicitly, as for example:
restrict -4 defaultSo before the fix
-4was treated as an address anddefaultas an *option what is wrong.With the new lense, cfa will read the IP version correctly.
IN PROCCESS
We need updated packages.