Skip to content

Commit

Permalink
Less strict low memory detection (bsc#1045915)
Browse files Browse the repository at this point in the history
There might be some rounding in the hwinfo memory size detection

- 3.3.0
  • Loading branch information
lslezak committed Jul 20, 2017
1 parent 2bb6dcd commit d08743c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
7 changes: 7 additions & 0 deletions package/yast2-packager.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
-------------------------------------------------------------------
Thu Jul 20 06:44:42 UTC 2017 - lslezak@suse.cz

- Less strict low memory detection, there might be some rounding
in the hwinfo memory size detection (bsc#1045915)
- 3.3.0

-------------------------------------------------------------------
Tue Jul 11 14:41:58 UTC 2017 - lslezak@suse.cz

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-packager.spec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


Name: yast2-packager
Version: 3.2.24
Version: 3.3.0
Release: 0

BuildRoot: %{_tmppath}/%{name}-%{version}-build
Expand Down
5 changes: 3 additions & 2 deletions src/clients/inst_productsources.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1736,8 +1736,9 @@ def RunMain
# display a warning when online repositories are used on a system
# with low memory (the installer may crash or freeze, see bnc#854755)
def check_memory_size
# less than LOW_MEMORY_MIB RAM
if Mode.installation && Yast2::HwDetection.memory < (LOW_MEMORY_MIB << 20)
# less than LOW_MEMORY_MIB RAM, the 64MiB buffer is for possible
# rounding in hwinfo memory detection (bsc#1045915)
if Mode.installation && Yast2::HwDetection.memory < ((LOW_MEMORY_MIB - 64) << 20)
Report.Warning(_("Low memory detected.\n\nUsing online repositories " +
"during initial installation with less than\n" +
"%dMiB system memory is not recommended.\n\n" +
Expand Down

0 comments on commit d08743c

Please sign in to comment.