[SLE-9109] Packages online search #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
Jan 22, 2020
src/clients/sw_single.rb
Outdated
| @@ -456,8 +456,9 @@ def GetPackagerOptions | |||
| end | |||
| end | |||
| repo_management = Mode.normal if repo_management.nil? | |||
| online_search = Mode.normal && Yast::WFM.ClientExists("online_search") | |||
There was a problem hiding this comment.
What if the system is not registered at all? How is that handled?
There was a problem hiding this comment.
It will be registered before registering the addons (see https://github.com/yast/yast-registration/pull/467/files#diff-57bedceb5faafb5d70b14b3357c09464R63).
There was a problem hiding this comment.
Please check also how it behaves in openSUSE Leap 15.1, you might create a reg code at https://scc.suse.com/admin/products/1929
lslezak
approved these changes
Jan 23, 2020
|
❌ Public Jenkins job #101 failed |
|
✔️ Internal Jenkins job #41 successfully finished |
|
✔️ Public Jenkins job #102 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, see the whole picture in yast/yast-registration#467.
This PR adds support to handle the online search dialog from the packager.