-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLE-9109] Packages online search #467
Conversation
I haven't checked the code yet, here are just some notes and hints for improvements 😉 UI/UX
Technical Questions
Todo Notes
I think that you could simply select the packages to install after adding the respective modules, the packager widget would then correctly display them as selected to install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some notes, except that "OMG" note it looks good 😃
Thanks for the early PR!
e9354df
to
f25623d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor notes, looks good!
* It uses the SUSEConnect API to find out packages in all modules, including those which have not been activated yet.
* Use just one column for information about the product. * Drop the "Toggle Package" button (it can be selected using the enter key). * Make clear which is the expected input in the search box.
e559349
to
ac139f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
❌ Public Jenkins job #66 failed |
❌ Internal Jenkins job #28 failed |
❌ Internal Jenkins job #29 failed |
This PR is an initial implementation of the online search feature SLE 9109. It is rather incomplete, but it is already able to search for packages and register modules as needed.
Selecting a package from an unregistered module for installation
Displaying package details (including version and module where it belongs to)
The menu option to start the online search
Todo