Fix random jumps when moving cursor in TUI repository table (bsc#1177145) #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…145) In ncurses, ChangeWidget(:table, :CurrentItem, ...) will be wrong for sorted tables (which is the default now). It is related to the ChangeWidget(:table, Cell(.., ..), ...) bug, bsc#1165388 This is a workaround: removing the unnecessary ChangeWidget.
mvidner
force-pushed
the
table-jumping-cursor
branch
from
d39a670
to
d7474f6
Compare
lslezak
reviewed
Oct 13, 2020
| fillCurrentRepoInfo | ||
| end | ||
| current = -1 if current.nil? | ||
| fillCurrentRepoInfo if current >= 0 |
There was a problem hiding this comment.
How does this change affect GUI (Qt)? Does it work properly or do we need if UI.TextMode condition?
There was a problem hiding this comment.
Good point. I've checked, it works OK in Qt.
lslezak
approved these changes
Oct 23, 2020
|
@joseivanlopez for master this is not necessary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ncurses,
ChangeWidget(:table, :CurrentItem, ...)will be wrong for sorted tables (which is the default now).It is related to the
ChangeWidget(:table, Cell(.., ..), ...)bug, bsc#1165388 (see libyui/libyui-ncurses#100)This is a workaround: removing the unnecessary ChangeWidget.
I tested that it works in ncurses and qt. It has been validated by the reporter.