Added the Pkg.Resolvables() and Pkg.AnyResolvable() calls #114
Conversation
- Related to bsc#1132650 - 4.2.0
| **Obsolete** | ||
|
|
||
| This call is obsolete, use `Resolvables()` call instead, it has more filtering | ||
| options and allows to return only the selected keys (saves memory and time). |
There was a problem hiding this comment.
do we want to put here deadline for removal? like SLE16?
There was a problem hiding this comment.
Um, I'm not sure, there are more than 100 calls of these old methods in YaST, it would mean we have to fix it until that time. 😉
There was a problem hiding this comment.
or when we get report about out of memory :) It is up to you, but my experience is that with no deadline, no removal will happen :)
src/Resolvable_Properties.cc
Outdated
| // status | ||
| std::string stat; | ||
| std::string resolvable_summary = item->summary(); | ||
| if ((all && !resolvable_summary.empty()) || attrs->contains(YCPSymbol("summary"))) |
There was a problem hiding this comment.
this looks a bit inconsistent to me e.g. to epoch, which is written always and here it is filtered if empty.
There was a problem hiding this comment.
That's for the backward compatibility with the old Pkg.ResolvableProperties call (sets all=true), which tries to save memory some by omitting some empty values.
For the new call it is added only if it is required (symbol included in the list) regardless the actual value.
I didn't want to change the behavior of the old call, some code depends on that behavior.
|
❌ Public Jenkins job #13 failed |
|
❌ Public Jenkins job #14 failed |
|
❌ Public Jenkins job #15 failed |
|
✔️ Um, the Jenkins has some network problems with OBS, submitted manually in SR#705577. |
|
✔️ Public Jenkins job #16 successfully finished |
|
✔️ Internal Jenkins job #1 successfully finished |
Pkg.ResolvablePropertiesandPkg.IsAnyResolvableDetails
Note: There is a nice Ruby wrapper for these Pkg calls in
Y2Packager::Resolvableclass (see yast/yast-packager#442).