Set additional compatible vendors with the call SetAdditionalVendors #138
Conversation
schubi2
changed the title
src/Package.cc
Outdated
| * @short set additional vendors which are compatible | ||
| * @description | ||
| * Select additional compatible vendors for installation. | ||
| * @param list<string> List of additional vondor strings |
There was a problem hiding this comment.
| * @param list<string> List of additional vondor strings | |
| * @param list<string> List of additional vendor strings |
src/Package.cc
Outdated
| * | ||
| * @short set additional vendors which are compatible | ||
| * @description | ||
| * Select additional compatible vendors for installation. |
There was a problem hiding this comment.
I think it's mainly used during upgrade...
| * Select additional compatible vendors for installation. | |
| * Select additional compatible vendors for upgrade. |
src/Package.cc
Outdated
|
|
||
| try | ||
| { | ||
| if ( zypp::getZYpp()->getTarget() ) { |
There was a problem hiding this comment.
Use the zypp_ptr() wrapper instead of calling zypp::getZYpp() directly.
| if ( zypp::getZYpp()->getTarget() ) { | |
| if ( zypp_ptr()->getTarget() ) { |
src/Package.cc
Outdated
| if ( zypp::getZYpp()->getTarget() ) { | ||
| zypp::VendorAttr vendorAttr { zypp::getZYpp()->getTarget()->vendorAttr() }; | ||
| vendorAttr.addVendorList(vendors); | ||
| zypp::getZYpp()->getTarget()->vendorAttr( std::move(vendorAttr) ); |
There was a problem hiding this comment.
| zypp::getZYpp()->getTarget()->vendorAttr( std::move(vendorAttr) ); | |
| zypp_ptr()->getTarget()->vendorAttr( std::move(vendorAttr) ); |
src/PkgFunctions.h
Outdated
| @@ -686,6 +686,8 @@ class PkgFunctions | |||
| YCPValue GetSolverFlags(); | |||
| /* TYPEINFO: boolean(map<string,any>)*/ | |||
| YCPValue SetSolverFlags(const YCPMap& params); | |||
| /* TYPEINFO: void(list<string>) */ | |||
There was a problem hiding this comment.
Then
| /* TYPEINFO: void(list<string>) */ | |
| /* TYPEINFO: boolean(list<string>) */ |
| * @usage Pkg::SetAdditionalLocales(["openSUSE","SUSE LLC"]); | ||
| */ | ||
| YCPValue | ||
| PkgFunctions::SetAdditionalVendors (const YCPList &vendorycplist) |
There was a problem hiding this comment.
Um, this is only "write" function. Could we also implement a read counterpart SetAdditionalVendors()? Just to make it symmetric. Sometimes it can be useful to know the current state.
There was a problem hiding this comment.
Hm VendorAttr in libzypp has not such kind of call. Do you see it ?
There was a problem hiding this comment.
| * @usage Pkg::SetAdditionalLocales(["openSUSE","SUSE LLC"]); | ||
| */ | ||
| YCPValue | ||
| PkgFunctions::SetAdditionalVendors (const YCPList &vendorycplist) |
There was a problem hiding this comment.
|
❌ Internal Jenkins job #17 failed |
|
✔️ Public Jenkins job #34 successfully finished |
|
❌ Internal Jenkins job #18 failed |
|
❌ Internal Jenkins job #19 failed |
|
❌ Internal Jenkins job #20 failed |
|
❌ Internal Jenkins job #21 failed |
|
❌ Internal Jenkins job #22 failed |
|
❌ Internal Jenkins job #23 failed |
|
❌ Internal Jenkins job #24 failed |
|
❌ Internal Jenkins job #25 failed |
|
❌ Internal Jenkins job #26 failed |
|
✔️ Internal Jenkins job #27 successfully finished |
No description provided.