Adapted package translation on the required amount of packages #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
May 25, 2020
src/modules/ProductCreator.rb
Outdated
| Exec( | ||
| Builtins.sformat( | ||
| "rm %1/%2/%3/setup/descr/packages.*", | ||
| String.Quote(basedir), |
There was a problem hiding this comment.
This will not work when the basedir contains a space. There were quite some bug reports about this in the past, it seems users really use spaces in directory names... 😉
String.Quote is designed to be used inside single quotes, so this quoting will not work properly.
As we cannot use single quotes here I'd use Shellwords here:
basedir.shellescape,
subdir.shellescape,
datadir.shellescape(+ add require "shellwords" ad the top).
Merged
schubi2
added a commit
that referenced
this pull request
May 25, 2020
This was referenced Nov 17, 2020
schubi2
added a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While creating a new image the suse/setup/desc/packages.<language>.gz files will not be updated.
This produces an error while package installation. The package will not be found on the repo.
Solution
Deleting these corrupted files. So libzypp will not take it in account anymore.