Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed check for registered status (bnc#886116) #130

Merged
merged 1 commit into from Jul 8, 2014
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jul 8, 2014

  • 3.1.89

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8cfd1e5 on registered_fix into f3d0f05 on master.

@@ -109,7 +109,8 @@ def activated_products
end

def self.is_registered?
SUSE::Connect::System.registered?
# just a simple file check without connection to SCC
File.exist?(SCC_CREDENTIALS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it check if this base system is registered or any system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple check for system registration.

In most cases it is sufficient, in some special cases it would would be better to check the base product registration, but that should be placed in a separate method (it requires connecting to the SCC server).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so LGTM

lslezak added a commit that referenced this pull request Jul 8, 2014
fixed check for registered status (bnc#886116)
@lslezak lslezak merged commit 52430de into master Jul 8, 2014
@lslezak lslezak deleted the registered_fix branch July 8, 2014 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants