Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed check for registered status (bnc#886116) #130

Merged
merged 1 commit into from Jul 8, 2014
Merged

fixed check for registered status (bnc#886116) #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions package/yast2-registration.changes
View file
Open in desktop
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Tue Jul 8 09:22:44 UTC 2014 - lslezak@suse.cz

- fixed check for registered status (bnc#886116)
- 3.1.89

-------------------------------------------------------------------
Mon Jul 7 13:46:45 UTC 2014 - lslezak@suse.cz

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-registration.spec
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@


Name: yast2-registration
Version: 3.1.87
Version: 3.1.88
Release: 0

BuildRoot: %{_tmppath}/%{name}-%{version}-build
Expand Down
3 changes: 2 additions & 1 deletion src/lib/registration/registration.rb
View file
Open in desktop
Expand Up @@ -109,7 +109,8 @@ def activated_products
end

def self.is_registered?
SUSE::Connect::System.registered?
# just a simple file check without connection to SCC
File.exist?(SCC_CREDENTIALS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it check if this base system is registered or any system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple check for system registration.

In most cases it is sufficient, in some special cases it would would be better to check the base product registration, but that should be placed in a separate method (it requires connecting to the SCC server).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so LGTM

end

private
Expand Down