Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the abort button when calling the network client #533

Merged
merged 2 commits into from Apr 7, 2021
Merged

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Apr 6, 2021

Problem

When user presses Abort button on Network settings page, it works same way as "Back" button and returns to the previous dialog. — https://bugzilla.suse.com/show_bug.cgi?id=1183586

As stated in the second comment, this happens

because the network subworkflow should not use [Abort] (...) It should be possible to abort only in the main workflow.

Solution

To use an installation argument (hide_abort_button) when calling the inst_lan client to force it hiding the abort button during the installation. See yast/yast-network#1195

Tests

  • Only tested manually using yupdate to apply changes in a SLE 15-SP3 Build 168.1

Screenshots

Patching the installer The client running in an installation sub-workflow, w/o the abort button
Patching the SUSE SLE installer via yupdate Network inst_lan client without the abort button

Related Trello card (internal link): https://trello.com/c/6M4weND5

Since it will be called in a installation sub-workflow, the abort button
will not work as expected.

See https://bugzilla.suse.com/show_bug.cgi?id=1183586
@dgdavid dgdavid requested a review from teclator April 6, 2021 16:28
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.099% when pulling ae70ff9 on bsc-1183586 into eac070c on master.

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 032e600 into master Apr 7, 2021
@dgdavid dgdavid deleted the bsc-1183586 branch April 7, 2021 14:58
@yast-bot
Copy link
Contributor

yast-bot commented Apr 7, 2021

✔️ Public Jenkins job #111 successfully finished
✔️ Created OBS submit request #883635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants