Hide the abort button in a network subworkflow during installation #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the inst_lan client is called from a sub-workflow, and abort is only possible in the main workflow.
dgdavid
commented
Apr 5, 2021
dgdavid
commented
Apr 5, 2021
|
The main problem I see is when it is called from the main workflow: https://github.com/yast/skelcd-control-leanos/blob/master/control/control.leanos.xml#L565 Currently we are hiding it always during an installation or update. BTW: I will try to check it deeper or later |
Instead of hiding the abort button unconditionally, it does it according to `disable_abort_button` inst argument. That's specially useful for avoiding not having such button when the client is used in the main installation workflow, keeping the installation UI consistence.
dgdavid
changed the title
dgdavid
changed the title
dgdavid
requested review from
ancorgs
and removed request for
imobachgs and
lslezak
|
Ey @teclator Thanks a lot for your chat and hints today afternoon. I have updated the PR to use the new Please, have a look again when you have time. |
teclator
reviewed
Apr 7, 2021
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.com>
This was referenced Apr 7, 2021
|
✔️ Public Jenkins job #238 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As stated in the second comment, this happens
Solution
To use an installation argument (
hide_abort_button) for setting when the abort button should be hide, since hiding it always during installation will break the installation UI consistence when the client is used in the main workflow.Notes
As it can be seen in the proposed changes, the call to
Yast::Wizard.HideAbortButtonhas been placed in src/include/network/lan/complex.rb#MainDialogmethod, since trying to place it somewhere before in the backtrace does not work (it worked forYast::Wizard::DisableAbortButtonbut not for hiding it, which actually worked partially being hide and displayed again 😕).For the record, the full path is
src/lib/network/clients/inst_lan.rb -> src/include/network/lan/wizards.rb#LanSequences -> src/include/network/lan/wizards.rb#MainSequence -> src/include/network/lan/complex.rb#MainDialog
Tests
yupdateto apply changes in a SLE 15-SP3 Build 168.1Screenshots
Related Trello card (internal link): https://trello.com/c/6M4weND5