test cyclic includes #101
Merged
test cyclic includes #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module Yast | ||
| describe ".include" do | ||
| it "does not loop endlessly on cyclic includes" do | ||
| expect { Yast.include(Yast, "cyclic_yin.rb") }.not_to raise_error |
There was a problem hiding this comment.
only annoying part is that it modify Yast module. maybe better use new class to avoid possible problems in other tests. also I think that this belongs to yast_spec.rb file as it test Yast.include
|
@mvidner I update code, please can you check it if you agree with it? ( ruby dynamic class creation is maybe little magic, but one test do not modify others ) |
|
Thank you! As discussed, I disliked the metaprogramming at first, but I concede that it is just a small amount of easy magic, which indeed helps code locality. Please make yast_spec.rb executable, then LGTM. |
|
@mvidner done + use format doc for rspec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an after-hotfix amendment to #100. @jreidinger what do you think? I have verified that this test fails when cherry-picked before 100 is applied.