Remove old testsuite #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is fragile and is somehow stopping the YaST evolution, apart from causing compatibility problems with Ruby 2.7 and making Travis fail. From now on, all new/edited code should be properly tested not relying in the log output and, ideally, using RSpec.
|
Hey @yast/samba-team, friendly ping here :) Although I requested review from other YaST team members, I'd like to have a review from you too :) Thanks in advance! |
ancorgs
reviewed
May 27, 2020
|
The remaining tests in Also, we BuildRequire several samba packages, probably unnecessarily. |
mvidner
approved these changes
May 28, 2020
|
lgtm |
dmulder
approved these changes
May 28, 2020
|
✔️ Public Jenkins job #20 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The legacy test suite, which makes testing by output to log, is a blocker for the evolution of YaST and is causing compatibility problems with Ruby 2.7 failing to build in Staging:J.
Solution
The YaST team has been trying to migrate as much as possible all legacy YaST module test suites to RSpec. However, among others this module is mainly written in Perl and we didn't find a good Perl-mocking tool to make that it less fragile and more useful.
Looking at the history of changes it can be seen that those tests (and the related code) have been mostly untouched for ages, which helps to make the decision of getting rid of them and move on.
So, this PR completely deletes the old test suite without any replacement. Of course, it can be checked any time whether needed thanks to the version control history. Ideally, every new change from now on should be tested with RSpec, although it still needed either, to migrate the existing Perl code to Ruby or find out the way to mock it properly in order to use RSpec for writing the tests.
Other changes
BuildRequires has been also updatedThanks to @mvidner for the clue
See also yast/yast-samba-client#84