Support for optional string and map types #76
Conversation
imobachgs
changed the title
… (bsc#1172131) jing depends on Java JRE but that is pulled in by trang already
Why both? The stars show their strong points: | | jing | xmllint | |----------------------------+-----------+-----------------| | runtime dependencies | big (JRE) | * small (glibc) | | detects invalid documents | yes | yes | | explains what is wrong | | | | ... with invalid documents | * yes | no |
|
@imobachgs I have checked with I want to break it by introducing a check on the correctness of the schema, in thefollowing commits. Also, https://ci.opensuse.org/view/Yast/job/yast-yast-schema-master/39/console is failing for lack of memory(?). |
imobachgs
changed the title
|
Josef has noted that the schema check should prehaps run at regular intervals, not just when this package changes, because it mostly breaks because of the dependencies. |
| @@ -29,6 +29,8 @@ License: GPL-2.0-or-later | |||
| Url: https://github.com/yast/yast-schema | |||
|
|
|||
| # Dependencies needed to build the package | |||
| BuildRequires: jing | |||
There was a problem hiding this comment.
Um, this will pull in whole Java stack as a dependency. 😟
I guess the OBS guys will not be happy about this...
I think it would be better to run the check regularly at Travis or Jenkins.
Or would it be enough just to use xmllint? That's much smaller...
There was a problem hiding this comment.
Yes it does pull in the JRE but we already must use Trang which also needs it, so it's not a new dependency.
|
❌ Public Jenkins job #40 failed |
Update
BuildRequiresdependencies. Please, do not merge this PR until all modules are adapted.Trello: https://trello.com/c/HkFkUQHj/1791-3-continue-with-new-xml-parser-xml-validation
Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1170886
To fix up things properly, all of these are needed together:
but it won't build without Remove old testsuite yast-samba-server#82 which it has a conflicting changelog with)