Code cleanup and some fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
force-pushed
the
pre907907_cleanup
branch
from
ac98c3e
to
63a1f85
Compare
| @@ -118,7 +118,12 @@ def initialize_security_dialogs(include_target) | |||
|
|
|||
| # mapping for "Enable" and "Disable" links | |||
| # current value -> new value | |||
| @link_value_mapping = { "yes" => "no", "no" => "yes" } | |||
| @link_value_mapping = { | |||
|
I think when you have tests then there is space for bigger refactoring, but in general LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup and tests needed in order to be able to work on bnc#907907 with confidence.
Sorry for not separating in commits the zombie killing from the spliting into smaller methods, but the latter is very simple (just moving the code a little bit).
https://bugzilla.suse.com/show_bug.cgi?id=907907