Cleanup and delete multiple snapshots at once (#bsc#956143). #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unified SnapperDbus and Snapper test in one file - Added tests for Snapper.ReadConfigs - Added tests for SnapperDialogsInclude#snapshot_modified
- Spliting some big methods trying to isolate its behavior to be easier for read, understood and rewrite.
| Convert.convert(new, :from => "map", :to => "map <string, any>") | ||
| ) { |key, value| ret = ret || Ops.get(orig, key) != value } | ||
| ret | ||
| new.map do |k,v| |
There was a problem hiding this comment.
map? it is not good one. Better use each and the best ruby is probably:
new.any? { |k, v| orig[k] != v }
| Yast.import "Snapper" | ||
|
|
||
|
|
||
| describe "Yast::Snapper" do |
|
in general nice improvement, just some code parts needs improvement. For tests I know it is just move, but if you touch it, it can be improved. The majority of comments are nitpick, but some of it should be addressed (especially map overusage). |
|
This bug will be fixed in PR #40. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not merge if more tests coverage is needed. I will be working on it and also in refacor/cleanup code.