[WIP] Added subclass for recognize InfiniBand cards (bsc#903190) #383
Conversation
| Fri Feb 12 17:31:48 UTC 2016 - knut.anderssen@suse.com | ||
|
|
||
| - bsc#903190 | ||
| - Recognized netcards with subclass 02 as InfiniBand (ib) which |
There was a problem hiding this comment.
- AFAIK it should be 06
- I'd go for more "user's" friendly description here. Something like "Improved detection of InfiniBand cards".
teclator
changed the title
| subclass_id = Ops.get_integer(hwdevice, "sub_class_id", -1) | ||
| return "modem" if hwdevice["subclass"] == "Modem" || modem_controller?(class_id) | ||
| return "isdn" if hwdevice["subclass"] == "ISDN" || isdn_controller?(class_id) | ||
| return "dsl" if hwdevice["subclass"] == "DSL" || dsl_controller?(class_id) |
There was a problem hiding this comment.
I think, when refactoring this you should check if these returns are needed ... modem / isdn / dsl support was dropped from yast some time ago
There was a problem hiding this comment.
So if it was dropped i could drop all references for it and for example only support ReadHardware("netcard")
teclator
force-pushed
the
mellanox_support
branch
from
5dfc256
to
a6fdb27
Compare
| # Read HW information | ||
| # @param [String] hwtype type of devices to read (netcard|modem|isdn) | ||
| # Read HW netcards information | ||
| # @param [String] not needed anymore |
There was a problem hiding this comment.
I think correct comment is do nothing unless empty or "netcard".
teclator
force-pushed
the
mellanox_support
branch
3 times, most recently
from
58a5a1b
to
573e659
Compare
|
|
||
| - bsc#903190 | ||
| - Recognized netcards with subclass 07 as InfiniBand (ib) which | ||
| now are not filtered out. |
There was a problem hiding this comment.
This is the same description as for 3.1.143 below?!
There was a problem hiding this comment.
I see, apparently #385 was merged because this PR was taking too long?
There was a problem hiding this comment.
Exactly, the fix was merged but i will continue with the clean up, just after i finish with yast/yast-snapper#40 and yast/yast-snapper#39 i'm working on it currently.
teclator
force-pushed
the
mellanox_support
branch
from
2d8d406
to
fdfa1e7
Compare
|
I will create a new PR that will supersede this one. |
No description provided.