Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dbus dependency #45

Merged
merged 7 commits into from
Sep 12, 2017
Merged

Add dbus dependency #45

merged 7 commits into from
Sep 12, 2017

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Sep 12, 2017 •
edited
Loading

ancorgs
ancorgs approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious about why the builddrequires was there but the requires wasn't. I fear there must be a reason... but we will find out.

@ancorgs
Copy link
Contributor

ancorgs commented Sep 12, 2017

The dependency is missing in travis.

@ancorgs
Copy link
Contributor

ancorgs commented Sep 12, 2017

And, btw. There is no coveralls. Remember the rule - repository touched -> coveralls enabled

ancorgs
ancorgs requested changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Rejecting my approval based on travis and coveralls status.

@imobachgs imobachgs force-pushed the add-dbus-dependency branch 2 times, most recently from 3a95a35 to 57bd25e Compare September 12, 2017 08:31
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 57bd25e on add-dbus-dependency into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 394a2ce on add-dbus-dependency into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a45286e on add-dbus-dependency into ** on master**.

@imobachgs
Copy link
Contributor Author

@ancorgs Both dependencies were in yast-storage. Now that we have switched to yast-storage-ng the problem arises.

@imobachgs imobachgs force-pushed the add-dbus-dependency branch 2 times, most recently from 3887388 to 00dfe65 Compare September 12, 2017 09:30
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 092047e on add-dbus-dependency into ** on master**.

@imobachgs imobachgs merged commit b892b7e into master Sep 12, 2017
@imobachgs imobachgs deleted the add-dbus-dependency branch September 12, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorgs ancorgs ancorgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imobachgs @ancorgs @coveralls