New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial wrapper for BtrfsQgroup and associated methods #1163
Conversation
9c121c2
to
01b096d
Compare
e6bfed8
to
c4d8cde
Compare
c4d8cde
to
e2be277
Compare
# Although they can be organized in a tree hierarchy, we are only considering the | ||
# first level (level 0, actually), so they are associated to a single subvolume. | ||
# | ||
# @see man btrfs-qgroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @see man btrfs-quota
which contains some more high-level documentation to make sense of what this is all about.
I looked at man btrfs-qgroup
, and it's a particular useless piece of documentation, written for those who already know everything (like so much of the Btrfs documentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the two small things, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only a NP about returning nil.
Problem
Support for Btrfs qgroups was recently added to libstorage-ng, but it's not yet exposed in yast2-storage-ng.
Solution
Create the wrappers and all the methods needed in order to offer an API similar to the one at #1150.
When finished, this pull request will obsolete #1150
Testing