Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial wrapper for BtrfsQgroup and associated methods #1163

Merged
merged 2 commits into from Nov 16, 2020

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Nov 6, 2020

Problem

Support for Btrfs qgroups was recently added to libstorage-ng, but it's not yet exposed in yast2-storage-ng.

Solution

Create the wrappers and all the methods needed in order to offer an API similar to the one at #1150.

When finished, this pull request will obsolete #1150

Testing

  • Tested manually.
  • Unit tests included

@coveralls
Copy link

coveralls commented Nov 11, 2020

Coverage Status

Coverage increased (+0.006%) to 97.653% when pulling 7372e00 on ancorgs:btrfs_quotas into 20fe54f on yast:btrfs_subvols.

@ancorgs ancorgs force-pushed the btrfs_quotas branch 8 times, most recently from e6bfed8 to c4d8cde Compare November 12, 2020 10:47
@ancorgs ancorgs marked this pull request as ready for review November 12, 2020 10:48
# Although they can be organized in a tree hierarchy, we are only considering the
# first level (level 0, actually), so they are associated to a single subvolume.
#
# @see man btrfs-qgroup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @see man btrfs-quota which contains some more high-level documentation to make sense of what this is all about.

I looked at man btrfs-qgroup, and it's a particular useless piece of documentation, written for those who already know everything (like so much of the Btrfs documentation).

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two small things, otherwise LGTM.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a NP about returning nil.

src/lib/y2storage/btrfs_subvolume.rb Show resolved Hide resolved
src/lib/y2storage/filesystems/btrfs.rb Show resolved Hide resolved
@ancorgs ancorgs merged commit b2cff60 into yast:btrfs_subvols Nov 16, 2020
@ancorgs ancorgs deleted the btrfs_quotas branch November 16, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants