Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove question mark icon #1211

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Remove question mark icon #1211

merged 3 commits into from
Mar 11, 2021

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Mar 11, 2021

Problem

The recursive deletion confirm dialog includes a question mark icon it its heading which

Solution

Drop it.

Testing

  • Tested manually

Screenshots

Before After
dialog_using_the_question_mark_icon dialog_not_using_the_question_mark_icon

@coveralls
Copy link

coveralls commented Mar 11, 2021

Coverage Status

Coverage remained the same at 97.755% when pulling 63d46cc on remove-question-icon into 3d851b5 on master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, fix the typo.

package/yast2-storage-ng.changes Outdated Show resolved Hide resolved
@dgdavid dgdavid merged commit 83abaab into master Mar 11, 2021
@dgdavid dgdavid deleted the remove-question-icon branch March 11, 2021 16:23
@yast-bot
Copy link

✔️ Internal Jenkins job #168 successfully finished
✔️ Created IBS submit request #237833

@yast-bot
Copy link

✔️ Public Jenkins job #365 successfully finished
✔️ Created OBS submit request #878372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants