New mountby2 #1307
New mountby2 #1307
Conversation
src/lib/y2storage/blk_device.rb
Outdated
| @@ -791,7 +791,7 @@ def encrypt_with_method(method, dm_name, **method_args) | |||
| # | |||
| # @return [Filesystems::MountByType] | |||
| def preferred_mount_by | |||
| Filesystems::MountByType.best_for(self, possible_mount_bys) | |||
| Filesystems::MountByType.best_for(self, possible_mount_bys & Filesystems::MountByType.all) | |||
There was a problem hiding this comment.
I find this inconsistent with the way it's done for MountPoint. In MountPoint you redefined #possible_mount_bys to return a filtered list. Here, #possible_mount_bys still returns an unfiltered list and the filter is done at preferred_mount_by.
There was a problem hiding this comment.
well, reason here is that it is private method and this is its only usage. But I can make it consistent
| @@ -90,6 +90,14 @@ def udev_name(value) | |||
| end | |||
|
|
|||
| class << self | |||
|
|
|||
| alias_method :all_nonfiltered, :all | |||
There was a problem hiding this comment.
Inconsistent use of nonfiltered vs unfiltered (below, in the MountPoint class).
There was a problem hiding this comment.
and which one you prefer?
There was a problem hiding this comment.
Well, actually what we always do when we override a list or value coming from libstorage-ng is having storage_whatever for the raw value and then whatever for the converted one.
For consistency I guess we should have MountByType.storage_all vs MountByType.all and MountPoint#storage_possible_mount_bys vs MountPoint@possible_mount_bys.
|
❌ Public Jenkins job #441 failed |
|
✔️ Internal Jenkins job #228 successfully finished |
|
✔️ Public Jenkins job #442 successfully finished |
Problem
Libstorage-ng introduces new types for mount_by which causes failure in test suites and also other code is not adapted for it.
Solution
Adapt a code to skip newly added ones as there is no request to support them.
Testing