Adaptations needed for a richer DBus interface #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
changed the title
ancorgs
force-pushed
the
dbus_volumes
branch
2 times, most recently
from
fb07320
to
bccce3e
Compare
This has no impact on YaST because YaST would never store a failed proposal at StorageManager. So far, checks like StorageManager.instance.proposal.nil? are only performed in YaST-specific clients and dialogs, so this doesn't have any unexpected effect in Y2Storage as a library either.
ancorgs
force-pushed
the
dbus_volumes
branch
from
983f304
to
1fa2b2e
Compare
ancorgs
force-pushed
the
dbus_volumes
branch
from
1fa2b2e
to
eed719e
Compare
|
✔️ Public Jenkins job #446 successfully finished |
|
✔️ Internal Jenkins job #1132 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To implement the storage management we envision for the D-Installer we need the ability to run the
GuidedProposalwith a couple of customizations:desiredandminin D-Installer because it can be confusing).Solution
Implemented a new subclass
MinGuidedProposalthat tries only once using themin_sizeas starting point and ignoring thedesired_size. Surely inheritance is not the nicest mechanism but it works perfectly here and is the mechanism that was chosen to customize the GuidedProposal (eg.InitialGuidedProposal).Added two new flags to
VolumeSpecificationto ignore the automatic size adjustments.Added the possibility to store a failed proposal in the
StorageManager. That makes no sense in the context of YaST but is used in D-Installer (since the proposal is the only mechanism there to produce an staging devicegraph).Testing
Added unit tests for the new functionality