-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit maximal proposed size of EFI partition (bsc#1062775) #399
Conversation
It would be good to also update the tests and the autogenerated documentation to better reflect the new behavior. That is, in context "when aiming for the recommended size" do
let(:target) { :desired }
it "requires /boot/efi to be at least 500 MiB large" do
expect(efi_part.min_size).to eq 500.MiB
end
end
context "when aiming for the minimal size" do
let(:target) { :min }
it "requires /boot/efi to be at least 33 MiB large" do
expect(efi_part.min_size).to eq 33.MiB
end
end ...into these ones... context "when aiming for the recommended size" do
let(:target) { :desired }
it "requires /boot/efi to be exactly 500 MiB large" do
expect(efi_part.min_size).to eq 500.MiB
expect(efi_part.max_size).to eq 500.MiB
end
end
context "when aiming for the minimal size" do
let(:target) { :min }
it "requires /boot/efi to be between 33 MiB and 500 MiB large" do
expect(efi_part.min_size).to eq 33.MiB
expect(efi_part.max_size).to eq 500.MiB
end
end I have not tested it, but it should work like that. And, of course, run Am I asking too much? ;-) |
doc/boot-requirements.md
Outdated
@@ -1,183 +1,2 @@ | |||
|
|||
[//]: # (document was automatically created using 'rake doc:bootspecs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm... Why does this empties the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will update doc/boot-requirements.md
in a separate PR.
No description provided.