Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximal proposed size of EFI partition (bsc#1062775) #399

Merged
merged 5 commits into from
Oct 27, 2017
Merged

Limit maximal proposed size of EFI partition (bsc#1062775) #399

merged 5 commits into from
Oct 27, 2017

Conversation

jsrain
Copy link
Member

@jsrain jsrain commented Oct 27, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.529% when pulling 267ab17 on jsrain:master into 537abc9 on yast:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.573% when pulling b9a4f1d on jsrain:master into f149247 on yast:master.

@ancorgs
Copy link
Contributor

ancorgs commented Oct 27, 2017

It would be good to also update the tests and the autogenerated documentation to better reflect the new behavior. That is, in test/support/proposed_partitions_examples.rb change these lines...

context "when aiming for the recommended size" do
  let(:target) { :desired }

  it "requires /boot/efi to be at least 500 MiB large" do
    expect(efi_part.min_size).to eq 500.MiB
  end
end

context "when aiming for the minimal size" do
  let(:target) { :min }

  it "requires /boot/efi to be at least 33 MiB large" do
    expect(efi_part.min_size).to eq 33.MiB
  end
end

...into these ones...

context "when aiming for the recommended size" do
  let(:target) { :desired }

  it "requires /boot/efi to be exactly 500 MiB large" do
    expect(efi_part.min_size).to eq 500.MiB
    expect(efi_part.max_size).to eq 500.MiB
  end
end

context "when aiming for the minimal size" do
  let(:target) { :min }

  it "requires /boot/efi to be between 33 MiB and 500 MiB large" do
    expect(efi_part.min_size).to eq 33.MiB
    expect(efi_part.max_size).to eq 500.MiB
  end
end

I have not tested it, but it should work like that.

And, of course, run rake doc:bootspecs to refresh doc/boot-requirements.md.

Am I asking too much? ;-)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.573% when pulling 44382ae on jsrain:master into f149247 on yast:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.573% when pulling 44382ae on jsrain:master into f149247 on yast:master.

@@ -1,183 +1,2 @@

[//]: # (document was automatically created using 'rake doc:bootspecs')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm... Why does this empties the documentation?

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will update doc/boot-requirements.md in a separate PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.573% when pulling bbf0a78 on jsrain:master into f149247 on yast:master.

@jsrain jsrain merged commit 8419ff0 into yast:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants