Added Mountable#persistent? (needed for bsc#1073696) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lslezak
commented
Jan 9, 2018
lslezak
commented
- See also Ignore the partition with the installer (bsc#1073696) yast-packager#308
- 4.0.68
ancorgs
reviewed
Jan 9, 2018
src/lib/y2storage/mountable.rb
Outdated
| # @return [Boolen] true if the mount point is saved to /etc/fstab | ||
| # (and will be mounted at boot again), false otherwise | ||
| def persistent? | ||
| to_storage_value.mount_point.in_etc_fstab? |
There was a problem hiding this comment.
This can raise an exception if there is no mount point. This should be more robust:
to_storage_value.has_mount_point && to_storage_value.mount_point.in_etc_fstab?
ancorgs
reviewed
Jan 9, 2018
src/lib/y2storage/mountable.rb
Outdated
| @@ -88,6 +88,13 @@ def mountpoint=(path) | |||
|
|
|||
| alias_method :mount_point=, :mountpoint= | |||
|
|
|||
| # Is the mount persistent? | |||
| # @return [Boolen] true if the mount point is saved to /etc/fstab | |||
|
Adding a simple unit test should not be that hard. For example, assigning a mountpoint to an existing filesystem and verifying that it becomes persistent. I will try to provide some code as starting point, give me a sec. |
joseivanlopez
approved these changes
Jan 9, 2018
| # Is the mount persistent? | ||
| # | ||
| # @return [Boolean] true if the mount point is saved to /etc/fstab | ||
| # (and will be mounted at boot again), false otherwise |
There was a problem hiding this comment.
NP: I would add a "TODO" to say that this should be adapted once MountPoint wrapper class is there.
|
@ancorgs @joseivanlopez thank you very much for the review and the improvements! 👍 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.