Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoYaST: avoid repeating filesystem elements for Btrfs multidevice filesystems #993

Merged
merged 5 commits into from
Nov 7, 2019

Conversation

imobachgs
Copy link
Contributor

When exporting a Btrfs multidevice filesystem, the filesystem related information will be repeated for each component. For instance, the list of subvolumes will appear in all <partition> elements which are part of the Btrfs filesystem. See bsc#1148578.

Additionally, this PR prevents exporting the enable_snapshots element when the drive section does not contain the root filesystem. The reason for this change is that snapshots will be applied only to the root filesystem, so it does not make sense in any other drive.

@imobachgs imobachgs changed the title Ay omit filesystem attributes AutoYaST: omit filesystem attributes for Btrfs multidevice filesystems Nov 6, 2019
@imobachgs imobachgs changed the title AutoYaST: omit filesystem attributes for Btrfs multidevice filesystems AutoYaST: avoid repeating filesystem elements for Btrfs multidevice filesystems Nov 6, 2019
@coveralls
Copy link

coveralls commented Nov 6, 2019

Coverage Status

Coverage increased (+0.0004%) to 97.636% when pulling 2362cab on ay-omit-filesystem-attributes into bb65229 on master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a typo.

src/lib/y2storage/autoinst_profile/drive_section.rb Outdated Show resolved Hide resolved
@imobachgs imobachgs merged commit 5956042 into master Nov 7, 2019
@imobachgs imobachgs deleted the ay-omit-filesystem-attributes branch November 7, 2019 10:23
@yast-bot
Copy link

yast-bot commented Nov 7, 2019

✔️ Public Jenkins job #225 successfully finished
✔️ Created OBS submit request #746211

@yast-bot
Copy link

yast-bot commented Nov 7, 2019

✔️ Internal Jenkins job #48 successfully finished
✔️ Created IBS submit request #204639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants