Implement simple_mode -> label_proposal (FATE#322328) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
added a commit
to yast/yast-installation
that referenced
this pull request
Jan 16, 2017
Using - Partitioning yast/yast-storage#254 - Kdump yast/yast-kdump#71 Using some real data (badly formatted) for - Booting - Network
|
This is for yast/yast-installation#487 |
mvidner
force-pushed
the
all-in-one-overview
branch
2 times, most recently
from
1925e6c
to
f6aef31
Compare
mvidner
changed the title
mvidner
force-pushed
the
all-in-one-overview
branch
from
bebd563
to
5c76c26
Compare
mvidner
changed the title
teclator
reviewed
Jan 25, 2017
| @@ -108,6 +112,19 @@ def main | |||
| ) | |||
| Ops.set(@ret, "warning_level", :blocker) | |||
| end | |||
|
|
|||
| if @param["simple_mode"] | |||
| self.class.modified = false if self.class.modified.nil? | |||
There was a problem hiding this comment.
NP: this line is really needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/XDgl2dj7/816-13-casp-new-all-in-one-dialog
yast/yast-yast2#530
So far, the code is a placeholder that just mocks the UI, but already uses thesimple_modeAPI.