Improve knowing when first user is being created or edited

[dgdavid]

Problem

Reported bsc#1188068 has revealed that InstUserFirstDialog is using a not optimal way to know if the user is going to be created or edited (see comment#12). In fact, changes introduced at yast/yast-firstboot#126 broken it in a way that init_pw_for_root starts failing.

Solution

To use the Y2Users::ConfigElement#attached? method instead of relying on the password value, which looks prone to false positives.

However, the check has to be performed and stored at the time to initialize the dialog because the private InstUserFirsDialogt#user method attaches the user to the current configuration for validation purposes.

Tests

• Already unit tests still passing
• Manual tests: done via driver update in a TW installation. Everything seems work as expected.

[coveralls]

Pull Request Test Coverage Report for Build 1044443450

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 53.511%

---

Totals
Change from base Build 1033637596:	0.01%
Covered Lines:	2576
Relevant Lines:	4814

---

💛 - Coveralls

[joseivanlopez]

Looks good.

[joseivanlopez]

LGTM

[yast-bot]

✔️ Internal Jenkins job #23 successfully finished
✔️ Created IBS submit request #245326

[yast-bot]

✔️ Public Jenkins job #61 successfully finished
✔️ Created OBS submit request #907085