Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users clients #126

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Fix users clients #126

merged 4 commits into from
Jul 9, 2021

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 8, 2021

Problem

The dialog for configuring the root password is shown even though the option "Use password for root" was selected. This is happening because firstboot writes/reads from the system in each step. Because that, the client for root password is not able to detect if the user password was used for root. Note at that point the plain passwords are not available anymore to compare them.

Solution

The user client now remembers the plain user and root passwords. This makes possible to fix the issue and also to fill the password fields, giving the exactly same user experience as in the regular installation.

Testing

  • Added unit tests.
  • Manually tested.

@coveralls
Copy link

coveralls commented Jul 9, 2021

Pull Request Test Coverage Report for Build 1015081779

  • 56 of 56 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 15.618%

Totals Coverage Status
Change from base Build 986530643: 2.6%
Covered Lines: 206
Relevant Lines: 1319

💛 - Coveralls

@joseivanlopez joseivanlopez marked this pull request as ready for review July 9, 2021 12:10
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit c96f16f into yast:master Jul 9, 2021
@yast-bot
Copy link
Contributor

yast-bot commented Jul 9, 2021

✔️ Public Jenkins job #50 successfully finished
✔️ Created OBS submit request #905297

@yast-bot
Copy link
Contributor

yast-bot commented Jul 9, 2021

✔️ Internal Jenkins job #33 successfully finished
✔️ Created IBS submit request #244627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants