Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document relationship of WriteSecurity and Y2Users writer #337

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 5, 2021

This is part of the big modification we are doing in the separate y2users branch in order to ensure the interactive module of YaST2 uses the shadow tools under the hood.

We were not sure whether the UI option "Expert Options -> Password Encryption" would still work after the changes. It does work correctly and this pull request simply adds a comment explaining why.

In short, changing the option takes effect immediately and will affect all the users created after altering the value. Users created in the same YaST execution but before changing the value retain the previous encryption method. The value is finally written to the login.defs configuration just to make it persistent, but not to affect the current execution.

@coveralls
Copy link

coveralls commented Oct 5, 2021

Pull Request Test Coverage Report for Build 1307460367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.193%

Totals Coverage Status
Change from base Build 1307082948: 0.0%
Covered Lines: 2849
Relevant Lines: 5070

💛 - Coveralls

@ancorgs ancorgs merged commit 241206b into yast:y2users Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants