Delete users and groups #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
delete-action
branch
from
42486c2
to
e867940
Compare
joseivanlopez
force-pushed
the
delete-action
branch
from
da38737
to
ac1eaa9
Compare
jreidinger
reviewed
Oct 6, 2021
jreidinger
reviewed
Oct 6, 2021
| # rubocop:disable Metrics/PerceivedComplexity | ||
| def usermod_options | ||
| args = [] | ||
| args << "--login" << user.name if user.name != initial_user.name && user.name |
There was a problem hiding this comment.
Maybe it makes sense to just always pass it? and if not, then I would maybe create method for it as it repeats often here.
jreidinger
reviewed
Oct 6, 2021
| # | ||
| # Issues are generated when the home cannot be cleaned up. | ||
| def run_action | ||
| Yast::Execute.on_target!(FIND, user.home.path, "-mindepth", "1", "-delete") |
There was a problem hiding this comment.
does find also find hidden files? and what about removing directory?
jreidinger
reviewed
Oct 6, 2021
jreidinger
reviewed
Oct 6, 2021
| remove_home_content(user) if !reusing_home && commit_config.home_without_skel? | ||
| set_home_ownership(user) if commit_config.adapt_home_ownership? | ||
| set_password(user) if user.password | ||
| set_auth_keys(user) |
There was a problem hiding this comment.
I have to say that it looks a bit strange to call methods here. I expect that you fill list of actions as needed and then pass it to some method to execute all actions.
joseivanlopez
force-pushed
the
delete-action
branch
2 times, most recently
from
03bd245
to
c11b0b0
Compare
joseivanlopez
force-pushed
the
delete-action
branch
from
c11b0b0
to
2d6f566
Compare
|
Closing in favor of #341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/XcAKT8r0/2657-3-deleting-users-with-y2users