Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 19 tumbleweed #20

Merged
merged 5 commits into from
Sep 13, 2017
Merged

Issue 19 tumbleweed #20

merged 5 commits into from
Sep 13, 2017

Conversation

zgock999
Copy link
Contributor

Fix Issue #19

  • Add method "check current target is Tumbleweed"
  • If it is Tumbleweed, set alternative pattern name

thx.

charlesa
charlesa requested changes May 31, 2017
View reviewed changes
Copy link
Contributor

@charlesa charlesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but the changelog entry needs to include the bug number (bsc#1040042). Could you please resubmit with that change?

charlesa
charlesa approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@charlesa charlesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jreidinger jreidinger merged commit 92fbac6 into yast:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesa charlesa charlesa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zgock999 @charlesa @jreidinger