avoid self assignment

yast · Jan 14, 2015 · 1f2295c · 1f2295c
1 parent babb257
commit 1f2295c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -86,10 +86,6 @@ Style/MethodName:
 Style/PredicateName:
   Enabled: false
 
-# Offense count: 2
-Style/SelfAssignment:
-  Enabled: false
-
 # Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAsExpressionSeparator.

diff --git a/library/cwm/src/modules/CWM.rb b/library/cwm/src/modules/CWM.rb
@@ -692,7 +692,7 @@ def validateWidgets(widgets, event)
       result = true
       Builtins.foreach(widgets) do |w|
         widget_key = Ops.get_string(w, "_cwm_key", "")
-        result = result && validateWidget(w, event, widget_key)
+        result &&= validateWidget(w, event, widget_key)
       end
       if !result && !@validation_failed_handler.nil?
         @validation_failed_handler.call

diff --git a/library/general/src/modules/ConfigHistory.rb b/library/general/src/modules/ConfigHistory.rb
@@ -310,8 +310,7 @@ def CheckChangedFilesOutOfVersionControl
               )
             )
         end
-        @commit_needed = @commit_needed ||
-          Ops.greater_than(Builtins.size(files), 0)
+        @commit_needed ||= Ops.greater_than(Builtins.size(files), 0)
         if Ops.greater_than(Builtins.size(files), 0)
           param = Builtins.mergestring(files, " ")
           out = Convert.to_map(