Skip to content

Commit

Permalink
DRY the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@lslezak
lslezak committed Mar 23, 2017
1 parent 45bbbfb commit 3c3f56b
Showing 1 changed file with 14 additions and 33 deletions.
47 changes: 14 additions & 33 deletions library/control/test/workflow_manager_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,22 @@
describe "#GetControlFileFromPackage" do
let(:repo_id) { 42 }
let(:product_package) { "foo-release" }
let(:product) { {"name" => "foo", "source" => repo_id, "product_package" => product_package} }
let(:ext_package) { "foo-installation" }
let(:extension) { {"name" => ext_package, "source" => repo_id} }
let(:release) { {"name" => product_package, "source" => repo_id,
"deps" => ["provides" => "installerextension(#{ext_package})"]} }

before do
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
allow(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
allow(Yast::Pkg).to receive(:ResolvableProperties).with(ext_package, :package, "").and_return([extension])
allow_any_instance_of(Packages::PackageDownloader).to receive(:download)
allow_any_instance_of(Packages::PackageExtractor).to receive(:extract)

# allow using it at other places
allow(File).to receive(:exist?).and_call_original
end

it "returns nil if the repository does provide any product" do
expect(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([])
Expand All @@ -291,73 +305,40 @@
end

it "returns nil if the product release package cannot be found" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
expect(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([])
expect(subject.GetControlFileFromPackage(repo_id)).to be nil
end

it "returns nil if the product release package does not have any dependencies" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => "foo", "source" => repo_id}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
expect(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
expect(subject.GetControlFileFromPackage(repo_id)).to be nil
end

it "returns nil if the product release package dependency do not match" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => "foo", "source" => repo_id, "deps" => ["provides" => "foo"]}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
expect(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
expect(subject.GetControlFileFromPackage(repo_id)).to be nil
end

it "returns nil if the installer extension package is not found" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => "foo", "source" => repo_id, "deps" => ["provides" => "installerextension(#{ext_package})"]}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
allow(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
expect(Yast::Pkg).to receive(:ResolvableProperties).with(ext_package, :package, "").and_return([])
expect(subject.GetControlFileFromPackage(repo_id)).to be nil
end

it "downloads and extracts the extension package" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => product_package, "source" => repo_id, "deps" => ["provides" => "installerextension(#{ext_package})"]}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
allow(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
allow(Yast::Pkg).to receive(:ResolvableProperties).with(ext_package, :package, "").and_return([extension])
expect_any_instance_of(Packages::PackageDownloader).to receive(:download)
expect_any_instance_of(Packages::PackageExtractor).to receive(:extract)
allow(File).to receive(:exist?)
subject.GetControlFileFromPackage(repo_id)
end

it "returns nil if the extracted package does not contain installation.xml" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => product_package, "source" => repo_id, "deps" => ["provides" => "installerextension(#{ext_package})"]}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
allow(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
allow(Yast::Pkg).to receive(:ResolvableProperties).with(ext_package, :package, "").and_return([extension])
allow_any_instance_of(Packages::PackageDownloader).to receive(:download)
allow_any_instance_of(Packages::PackageExtractor).to receive(:extract)
# allow using it at other places
expect(File).to receive(:exist?).and_call_original
expect(File).to receive(:exist?).with(/installation\.xml\z/).and_return(false)
expect(subject.GetControlFileFromPackage(repo_id)).to be nil
end

it "returns the installation.xml path nil if the extracted package contains it" do
product = {"name" => "foo", "source" => repo_id, "product_package" => product_package}
release = {"name" => product_package, "source" => repo_id, "deps" => ["provides" => "installerextension(#{ext_package})"]}
allow(Yast::Pkg).to receive(:ResolvableDependencies).with("", :product, "").and_return([product])
allow(Yast::Pkg).to receive(:ResolvableDependencies).with(product_package, :package, "").and_return([release])
allow(Yast::Pkg).to receive(:ResolvableProperties).with(ext_package, :package, "").and_return([extension])
allow_any_instance_of(Packages::PackageDownloader).to receive(:download)
allow_any_instance_of(Packages::PackageExtractor).to receive(:extract)
# allow using it at other places
expect(File).to receive(:exist?).and_call_original
expect(File).to receive(:exist?).with(/installation.xml\z/).and_return(true)
expect(subject.GetControlFileFromPackage(repo_id)).to match(/\/installation\.xml\z/)
end
Expand Down

0 comments on commit 3c3f56b

Please sign in to comment.