added more testcases

library/general/src/lib/cfa/sysctl_config.rb

@@ -99,7 +99,7 @@ def save
 
     # Whether there is a conflict with given attributes
     #
-    # @param only [Array<String,Symbol>] attributes to check
+    # @param only [Array<Symbol>] attributes to check
     # @return [Array<String>] list of conflicting files
     def conflict_files(only: [])
       return [] if yast_config_file.empty?
@@ -116,9 +116,7 @@ def conflict_files(only: [])
         # Checking all "higher" files if their values overrule the current
         # YAST settings.
         higher_attr = file.present_attributes
-        if conflicting_attrs.any? { |k, v| !higher_attr[k].nil? && v != higher_attr[k] }
-          file_list << file.file_path
-        end
+        file_list << file.file_path if conflicting_attrs.any? { |k, v| !higher_attr[k].nil? && v != higher_attr[k] }
       end
       file_list
     end

library/general/test/cfa/sysctl_config_test.rb

@@ -169,6 +169,34 @@
         end
       end
 
+      context "and specific attributes is given" do
+        context "attribute will be not found" do
+          it "returns empty list" do
+            expect(config.conflict_files(only: [:not_valid])).to be_empty
+          end
+        end
+
+        context "attribute is valid" do
+          context "when some main file value is overriden" do
+            let(:tcp_syncookies) { false }
+
+            it "returns file array" do
+              expect(config.conflict_files(only: [:tcp_syncookies]))
+                .to eq(["/etc/sysctl.conf"])
+            end
+          end
+
+          context "when no value is overriden" do
+            let(:tcp_syncookies) { true }
+
+            it "returns empty list" do
+              expect(config.conflict_files(only: [:tcp_syncookies]))
+                .to be_empty
+            end
+          end
+        end
+      end
+
       context "when some main file value is overriden" do
         let(:tcp_syncookies) { false }