change default action, added combobox

see http://lists.opensuse.org/opensuse-factory/2013-11/msg00667.html

library/general/src/fillup/sysconfig.yast2

@@ -56,14 +56,14 @@ STORE_CONFIG_IN_SUBVERSION="no"
 SUBVERSION_ADD_DIRS_RECURSIVE="no"
 
 ## Type: list(close,restart,summary)
-## Default: "close"
+## Default: "summary"
 # Set the default behavior of the package manager when package installation has finished.
 # Possible actions are:
 #   close - just finish the package manager
 #   restart - go back to the package manager, install/remove more packages
 #   summary - display an installation summary dialog, there user can decide whether to finish or restart
 # The summary dialog is always displayed when an installation error has occured.
-PKGMGR_ACTION_AT_EXIT="close"
+PKGMGR_ACTION_AT_EXIT="summary"
 
 ## Type: list(yes,no)
 ## Default: "yes"

library/packages/src/modules/PackagesUI.rb

@@ -419,7 +419,6 @@ def FormatPackageList(pkgs, link)
     end
 
     def InstallationSummary(summary)
-      summary = deep_copy(summary)
       ret = ""
 
       if Builtins.haskey(summary, "success")
@@ -637,14 +636,15 @@ def ShowDetailsList(heading, pkgs)
 
 
     def ShowInstallationSummaryMap(summary)
-      summary = deep_copy(summary)
       summary_str = InstallationSummary(summary)
 
-      if summary_str == nil || summary_str == ""
+      if summary["installed"] == 0 && summary["updated"] == 0 && summary["removed"] == 0 && summary["remaining"] == []
         Builtins.y2warning("No summary, skipping summary dialog")
         return :next
       end
 
+      Builtins.y2milestone("Displaying installation report: #{summary.inspect}")
+
       wizard_opened = false
 
       # open a new wizard dialog if needed
@@ -653,16 +653,28 @@ def ShowInstallationSummaryMap(summary)
         wizard_opened = true
       end
 
-      dialog = RichText(Id(:rtext), summary_str)
+      current_action = SCR.Read(path(".sysconfig.yast2.PKGMGR_ACTION_AT_EXIT"))
+
+      dialog = VBox(
+        RichText(Id(:rtext), summary_str),
+        Left(
+          ComboBox(Id(:action), _("After Installing Packages"), [
+            Item(Id("summary"), _("Show This Report"), current_action == "summary"),
+            Item(Id("close"), _("Finish"), current_action == "close"),
+            Item(Id("restart"), _("Continue in the Software Manager"), current_action == "restart")
+          ])
+        )
+      )
 
       help_text = _(
-        "<P><BIG><B>Installation Summary</B></BIG><BR>Here is a summary of installed packages.</P>"
+        "<P><BIG><B>Installation Report</B></BIG><BR>Here is a summary of installed or removed packages.</P>"
       )
 
       Wizard.SetNextButton(:next, Label.FinishButton)
+      Wizard.SetBackButton(:back, Label.ContinueButton)
 
       Wizard.SetContents(
-        _("Installation Summary"), #has_next
+        _("Installation Report"),
         dialog,
         help_text,
         true,
@@ -714,7 +726,26 @@ def ShowInstallationSummaryMap(summary)
 
       Builtins.y2milestone("Installation Summary result: %1", result)
 
+      new_action = UI.QueryWidget(Id(:action), :Value)
+
+      # the combobox value has been changed, save the new value
+      if result == :next && current_action != new_action
+        if new_action != "summary"
+          # disabling installation report dialog, inform the user how to enable it back
+          Popup.Message(_("If you want to show this report dialog again edit\n\n"+
+            "System > Yast2 > GUI > PKGMGR_ACTION_AT_EXIT\n\n" +
+            "value in the YaST sysconfig editor."))
+        end
+
+        Builtins.y2milestone("Changing PKGMGR_ACTION_AT_EXIT from #{current_action.inspect} to #{new_action.inspect}")
+
+        SCR.Write(path(".sysconfig.yast2.PKGMGR_ACTION_AT_EXIT"), new_action)
+        # flush
+        SCR.Write(path(".sysconfig.yast2"), nil)
+      end
+
       Wizard.RestoreNextButton
+      Wizard.RestoreBackButton
 
       if wizard_opened
         # close the opened window