Propagate an error status when a CommandLine module gets an unknown command #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
commented
Jan 6, 2020
| @@ -360,7 +360,7 @@ def Parse(arguments) | |||
| # translators: error message in command line interface | |||
| Error(Builtins.sformat(_("Unknown Command: %1"), command)) | |||
|
|
|||
| return { "command" => command } | |||
| return {} | |||
There was a problem hiding this comment.
This fix works because our caller actually obeys our API documented above
# @return [Hash{String => Object}] containing the command and it's option. In case of
# error it is an empty map.
Related to bsc#1144351. Found when testing the correct propagation of errors: A false from a YaST client should mean an error exit code.
mvidner
force-pushed
the
cli-unknown-is-error
branch
from
94ca82a
to
51789a0
Compare
jreidinger
approved these changes
Jan 10, 2020
|
✔️ Public Jenkins job #166 successfully finished |
|
✔️ Internal Jenkins job #64 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompted by the testing discussion in yast/yast-ruby-bindings#237
because I wanted to test that fix with
yast2 lan unknowncommandand it still did not work