add ability for WSL desktop file whitelisting #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2020
joseivanlopez
approved these changes
Feb 4, 2020
library/desktop/test/desktop_test.rb
Outdated
| @@ -34,9 +34,58 @@ | |||
| "add-on" => { "Name" => "YaST Add-On Products" }, | |||
| "lan" => { "Name" => "YaST Network" }, | |||
| "services-manager" => { "Name" => "YaST Services Manager" }, | |||
| "sw-single" => { "Name"=>"YaST Software Management" }, | |||
There was a problem hiding this comment.
NP: missing spaces around =>
|
Ups, there are conflicts. Please, fix them ;) |
|
@joseivanlopez fixed, I worry no one is familiar with this piece of code as it is ncurses only control center + desktop parses which is also not used often. |
|
✔️ Public Jenkins job #181 successfully finished |
|
✔️ Internal Jenkins job #79 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: WSL is limited environment, so many modules does not make sense to show. So whitelisting only ones that has specific key in desktop file.