[CWM] Add new widget to manage multi status selection lists #1029

dgdavid · 2020-03-11T10:22:10Z

Introduces a new RichText based widget to mange the multi stats selection,

Providing following features:

Allow to select more than one item.

Able to represent multiple statuses: no selected, selected, auto selected.

Able to represent disabled items.

Emit different events to distinguish the interaction through check box input or its label.

Automatic text wrapping.

Keep the vertical scroll.

Related to

coveralls · 2020-03-11T10:31:00Z

Coverage increased (+0.2%) to 31.028% when pulling ec99045 on cwm/multi_state_selector into c9d8c2b on master.

dgdavid · 2020-03-11T10:35:05Z

library/cwm/src/lib/cwm/multi_status_selector.rb

+      # Returns style rules for the text
+      #
+      # @return [String] the status text representation
+      def text_style
+        "text-decoration: none; color: #{color}"
+      end
+
+      # Determines the color for the text
+      #
+      # @return [String] "grey" for a disabled item;
+      #                  "white" when enabled and running in installation mode;
+      #                  "black" otherwise
+      def color
+        return "grey" unless enabled?
+        return "white" if installation?
+
+        "black"
+      end
+
+      # Determines whether running in installation mode
+      #
+      # We do not use Stage.initial because of firstboot, which runs in 'installation' mode
+      # but in 'firstboot' stage.
+      #
+      # @return [Boolean] Boolean if running in installation or update mode
+      def installation?
+        Yast::Mode.installation || Yast::Mode.update
+      end
+    end


Question: could we simply use a class attribute for those links and properly style them via .qss? Or is not possible because they are inside a RichText?

@lslezak, @shundhammer 👆 👆

library/cwm/src/lib/cwm/multi_status_selector.rb

library/cwm/test/multi_status_selector_test.rb

jreidinger · 2020-03-11T16:18:51Z

library/cwm/src/lib/cwm/multi_status_selector.rb

@@ -34,6 +34,10 @@ module CWM
  #
  # If you want to see it in action, have a look at yast2-registration or yast2-packager modules.
  #
+  # TODO: make possible to use it more than once in the same dialog, maybe by using the parent
+  # widget_id as a prefix for the event_id. See {CWM::MultiStatusSelector#handle} and
+  # {CWM::MultiStatusSelector::Item.event_id}.


yep, widget id as prefix for item sounds reasonable for me.

Perfect!

Let's keep the TODO there for the next iteration 🙄

Providing following features: - Allow to select more than one item. - Able to represent multiple statuses: no selected, selected, auto selected. - Able to represent disabled items. - Emit different events to distinguish the interaction through check box input or its label. - Automatic text wrapping. - Keep the vertical scroll.

yast-bot · 2020-03-12T09:58:37Z

✔️ Public Jenkins job #189 successfully finished
✔️ Created OBS submit request #784242

yast-bot · 2020-03-12T10:02:25Z

✔️ Internal Jenkins job #88 successfully finished
✔️ Created IBS submit request #213786

Based on CWM::MultiStatusSelector, recently added in yast2 4.2.72 See - yast/yast-yast2#1029 - https://github.com/yast/yast-yast2/blob/master/library/cwm/src/lib/cwm/multi_status_selector.rb

This reverts changes introduced in 4.2.59, which were an attempt to revamp the addons selection by using a RichText based selector widget. Finally, it does not play as well as expected since it seems to "trade one problem to another". To read more, see: * yast/yast-yast2#1029 * #515 * https://bugzilla.suse.com/show_bug.cgi?id=1167523#c10

This removes no longer needed RichText based selector widget, which was introduced in version 4.2.72 and polished in later in subsequent versions. To read more, see * #1029 (4.2.72) * #1031 (4.2.73) * #1032 (4.2.74) * #1035 (4.2.77) and * https://bugzilla.suse.com/show_bug.cgi?id=1167523#c10

dgdavid requested review from imobachgs and jreidinger March 11, 2020 10:23

dgdavid force-pushed the cwm/multi_state_selector branch from 680fed8 to 127d60b Compare March 11, 2020 10:26

dgdavid commented Mar 11, 2020

View reviewed changes