Remove deleted secondary IP addresses #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
remove_ip_addresses
branch
from
f80d321
to
f256cb9
Compare
teclator
force-pushed
the
remove_ip_addresses
branch
from
f256cb9
to
54f6762
Compare
teclator
changed the title
teclator
changed the title
imobachgs
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Removed secondary IP addresses through the yast2-network dialog are marked to be deleted but are not removed from the ifcfg files since (#789)
Solution
Delete not only removed interfaces but also removed secondary IP addresses.