Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnc#1081441 #1047

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Bnc#1081441 #1047

merged 2 commits into from
Sep 25, 2020

Conversation

srinidhibs
Copy link
Contributor

Display appropriate Bugzilla URL depending on the release name of the product on which the error occurred.

In case of an error, the error dialog will request the user to file a report on https://bugzilla.opensuse.org when the release name in /etc/os-release contains "openSUSE". For any other release name, the
Bugzilla URL displayed would be https://bugzilla.suse.com.

Screenshots

Before
Error Screenshot on any SUSE release

After (on openSUSE system)
Error Screenshot on openSUSE

I tested this by commenting out NAME= attribute from /etc/os-release file. In this case, the OSRelease.ReleaseName method will return the default value of "SUSE Linux" and in that case, https://bugzilla.suse.com URL is displayed to the user.

Fixes bsc#1081441

In case of an error, the error dialog will request user to file a report
on https://bugzilla.opensuse.org when the release name in
/etc/os-release contains "openSUSE". For any other release name, the
bugzilla URL displayed would be https://bugzilla.suse.com.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 31.071% when pulling 6bfab92 on srinidhibs:bnc#1081441 into fe1f0f8 on yast:master.

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for patch

@jreidinger jreidinger merged commit d0120e4 into yast:master Sep 25, 2020
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #252 successfully finished
✔️ Created OBS submit request #837279

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #117 successfully finished
✔️ Created IBS submit request #227290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants