add space to SPACE_CHARS (bsc#1173907) #1077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPACE_CHARS
https://github.com/yast/yast-yast2/blob/master/library/types/src/modules/String.rb#L42 doesn't include a space.This makes it impossible to work with ESSIDs containing a space. See
https://github.com/yast/yast-network/blob/master/src/lib/y2network/widgets/wireless_essid.rb#L95-L97
Solution
Add it.
Evil side effects
AFAICS
SPACE_CHARS
is only used inYast::String.CPrint
and that's only used in the ESSID dialog. So I wouldn't expect any evil fallout by this change.