Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector without opt #1104

Merged
merged 2 commits into from Sep 28, 2020
Merged

Fix selector without opt #1104

merged 2 commits into from Sep 28, 2020

Conversation

imobachgs
Copy link
Contributor

Fixes #1044 in case that the opt method is not defined.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 32.399% when pulling 773c6cb on fix-selector-without-opt into c7b90ff on master.

@@ -201,7 +201,7 @@ def value=(val)
private

def editable?
opt.include?(:editable)
respond_to?(:opt) && opt.include?(:editable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not editable by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not editable by default.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit a54ec44 into master Sep 28, 2020
@imobachgs imobachgs deleted the fix-selector-without-opt branch September 28, 2020 09:00
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #254 successfully finished
✔️ Created OBS submit request #838207

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #119 successfully finished
✔️ Created IBS submit request #227367

imobachgs added a commit to yast/yast-autoinstallation that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants