New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selector without opt #1104
Fix selector without opt #1104
Conversation
@@ -201,7 +201,7 @@ def value=(val) | |||
private | |||
|
|||
def editable? | |||
opt.include?(:editable) | |||
respond_to?(:opt) && opt.include?(:editable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not editable by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is not editable by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Public Jenkins job #254 successfully finished |
✔️ Internal Jenkins job #119 successfully finished |
* Related to yast/yast-yast2#1104
Fixes #1044 in case that the
opt
method is not defined.