Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rubocop susefirewall references #1105

Closed
wants to merge 1 commit into from
Closed

Remove rubocop susefirewall references #1105

wants to merge 1 commit into from
+0 −23

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Oct 1, 2020

The exceptions are not needed anymore as we already removed the files .. see #806

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.557% when pulling 251a0ae on rubocop_drop_susefirewall_excludes into 9c012c6 on master.

@teclator
Copy link
Contributor Author

teclator commented Oct 1, 2020

There are some modules that still import "SuSEFirewall2", thus, we have decided to revert the drop by now.

@teclator teclator closed this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger Awaiting requested review from jreidinger

@imobachgs imobachgs Awaiting requested review from imobachgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teclator @coveralls