Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsc#1177405: AutoYaST crashes with an empty <raid_options> section #1108

Merged
merged 2 commits into from Oct 7, 2020
Merged

bsc#1177405: AutoYaST crashes with an empty <raid_options> section #1108

merged 2 commits into from Oct 7, 2020

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Oct 7, 2020 •
edited

Fixes bsc#1177405. It does not try to import the information from a hash when it is not actually a hash.

<partition>
  <raid_options/>
</partition>

Is exported to:

{ raid_options: "" }

because there is not enough information to determine whether it is should be a string or a hash (the raid_options is supposed to be a hash).

@imobachgs imobachgs changed the title Bsc 1177405 bsc#1177405 Oct 7, 2020
@imobachgs imobachgs changed the title bsc#1177405 bsc#1177405: AutoYaST crashes with an empty <raid_options> section Oct 7, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 32.4% when pulling da04ae9 on bsc-1177405 into 888cdd1 on master.

ancorgs
ancorgs approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 1629c3a into master Oct 7, 2020
@imobachgs imobachgs deleted the bsc-1177405 branch October 7, 2020 19:54
@yast-bot
Copy link
Contributor

yast-bot commented Oct 7, 2020

✔️ Internal Jenkins job #122 successfully finished
✔️ Created IBS submit request #228100

@yast-bot
Copy link
Contributor

yast-bot commented Oct 7, 2020

✔️ Public Jenkins job #257 successfully finished
✔️ Created OBS submit request #840133

@imobachgs imobachgs mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorgs ancorgs ancorgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@imobachgs @coveralls @yast-bot @ancorgs