handle save_y2logs when content modified when creating tarball #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shundhammer
reviewed
Mar 8, 2021
scripts/save_y2logs
Outdated
| err=$? | ||
|
|
||
| rm -rf $TMPDIR | ||
|
|
||
| # tar returns 1 when content of tarball is older then current system. Happen when something still writting to logs or memsampler (bsc#1182710#c2) | ||
| [ $err == 1 ] && echo "Warning: logs modified during save. Yast is probably running. Content of tarball can be older then current content." >&2 && err=0 |
There was a problem hiding this comment.
older than
(user message, so not just NP)
shundhammer
reviewed
Mar 8, 2021
scripts/save_y2logs
Outdated
| err=$? | ||
|
|
||
| rm -rf $TMPDIR | ||
|
|
||
| # tar returns 1 when content of tarball is older then current system. Happen when something still writting to logs or memsampler (bsc#1182710#c2) |
There was a problem hiding this comment.
NP: older than the current system
jreidinger
force-pushed
the
fix_save_y2logs
branch
from
e51a767
to
5d9267a
Compare
|
✔️ Public Jenkins job #289 successfully finished |
|
✔️ Internal Jenkins job #149 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it looks now ( easy to reproduce with Y2DEBUG=1 and slide show ):
