Do not escape $ in URI path #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from being a valid path char according to RFC3986[1], $ char is used by the libzypp repository variables[2] and it must not be escaped for avoiding breaking their later expansion. [1] https://datatracker.ietf.org/doc/html/rfc3986#appendix-A (sub-delims) [2] https://doc.opensuse.org/projects/libzypp/HEAD/zypp-repovars.html
Do not escape $ in URI paths
[SLE-15-SP2] Do not escape $ in URI paths
See #1183 for details
Fix test broken in 8aab555
[SLE-15-SP2] Fix test broken in 8aab555
[SLE-15-SP3] Do not escape $ in URI path
lslezak
approved these changes
Jul 16, 2021
|
✔️ Public Jenkins job #318 successfully finished |
|
✔️ Internal Jenkins job #156 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bsc#1187581 for SLE-15-SP4, not escaping "$" when producing the URI from it component parts. See #1183 for more information.
Discouraging the use of
URLRecode(2021-07-28)We have added a kind of deprecation note pointed to
Y2Packager::ZyppUrl, which was added for dealing with libzypp urls. See #1191.OBS SR: https://build.opensuse.org/request/show/906609
IBS SR: https://build.suse.de/request/show/245247