do not strip surrounding white space in CDATA XML elements (bsc#1195910) #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not strip trailing white space in XML elements (bsc#1195910)
do not strip surrounding white space in CDATA XML elements (bsc#1195910)
jreidinger
approved these changes
Feb 17, 2022
|
✔️ Public Jenkins job #359 successfully finished |
|
✔️ Internal Jenkins job #193 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Port #1244 to SLE15-SP4/TW.
Original task
Surrounding white space in some elements may be desired. Like in scripts or other file content.
Solution
Do not strip surrounding white space when reading XML CDATA elements. And create CDATA elements when generating XML if an element contains surrounding white space.
Note
This reworks #1243.
I did some checks and prior to SLE15-SP3 we did preserve all white space in CDATA elements. This also does not pose a problem in script elements. Leading white space is ok there.
So, this pull request fully restores the old behavior.