Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed text mode control center in container (bsc#1199840) #1261

Merged
merged 1 commit into from Jul 22, 2022
Merged

Fixed text mode control center in container (bsc#1199840) #1261

merged 1 commit into from Jul 22, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jul 22, 2022 •
edited

Details

  • Always display the YaST modules installed in the system root
  • When running in a container display the modules installed in the container (originally it displayed the modules from the host system which might not contain any YaST module)
  • 4.5.7

Notes

  • The Qt control center is not affected, it always loads the files from the system root.
  • The started YaST modules run in a new separate process so they use the chrooting as expected, they correctly manage the host system

Screenshots

The Original Behavior

menu_broken

With the Fix Applied

menu_fixed

@lslezak
Fixed text mode control center in container (bsc#1199840)
cf6ff08 
- Always display the YaST modules installed in the system root
- When running in a container display the modules installed in
  the container
- 4.5.7
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 41.637% when pulling cf6ff08 on menu_in_container into 32217e5 on master.

jreidinger
jreidinger reviewed Jul 22, 2022
View reviewed changes
library/desktop/src/clients/menu.rb
# revert back the chrooting
handle = Yast::WFM.SCROpen("chroot=/:scr", false)
Yast::WFM.SCRSetDefault(handle)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and will be the started modules chrooted or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they will, it starts new subprocesses which have their own SCR instances.

@lslezak lslezak merged commit 03e8ef6 into master Jul 22, 2022
@lslezak lslezak deleted the menu_in_container branch July 22, 2022 13:22
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #373 successfully finished
✔️ Created OBS submit request #990692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @jreidinger